Does rtrdump actually downgrade the version?

bgp / stayrtr

RPKI-To-Router server implementation in Go

BSD 3-Clause "New" or "Revised" License

85 stars 13 forks source link

Does rtrdump actually downgrade the version? #122

Open partim opened 3 months ago

partim commented 3 months ago

We’re having an issue in Routinator (https://github.com/NLnetLabs/routinator/issues/950) where rtrdump fails to produce any output when not started with -rtr.version 1. It does print “Downgrading to version 1” but then seems to just close the connection. I did test with the fixed RTR server code that reports the expected version in the error PDU.

Can you confirm that this indeed because rtrdump doesn’t retry with the new version or is there something that Routinator does wrong?

ties commented 3 months ago

You can check what is sent with Wireshark.

I also hit this when using stayrtr as a library: there is a message but no actual version downgrade. I assumed this was an error in my usage.

partim commented 3 months ago

I checked with Wireshark – it just closes the connection after receiving the error. I’m asking because there were issues around this earlier and want to double check whether there are more fixes that are needed on my side.