search

bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
85 stars 13 forks source link

-version doesn't expose version #123

Open funzoneq opened 3 months ago

funzoneq commented 3 months ago 
/usr/bin/stayrtr -version
StayRTR

I know the package has a version number, but it would be nice to have this reflected in the version string of the build.

ties commented 2 months ago

This is odd. On my local machine I get

$ make
...
$ ./dist/stayrtr-v0.5.1-49-g3b91cfa-linux-x86_64 -version
StayRTR v0.5.1-49-g3b91cfa (2024-05-04T09:39:53+0200)

What source are you using for stayrtr?

randomthingsandstuff commented 2 months ago

its a link-time variable. if you don't use the makefile, you're not going to get it.

i can maybe make some autogen'ed shit or another to fix that for the go install or whatever, but i don't personally care. and i'm willing to spend a maximum of 30 min to sort it out.

edited: and time spent. vcsbuild info in go doesnt include the tag. would need to run go generate beforehand to bump the rev. not really useful.

makefile is the way from my pov.

funzoneq commented 2 months ago 
avermeer@rpki02-lab01:~$ dpkg -l stayrtr
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
ii  stayrtr        0.5.1-2+b1   amd64        RPKI to Router server

avermeer@rpki02-lab01:~$ /usr/bin/stayrtr --version
StayRTR

This is the pre-release package from github. I'm fine with whatever solution you use to generate the version number. But let's make sure that official releases include them as part of their normal release procedure.