Closed job closed 3 years ago
Discussed with @job, no objections from my side.
Quick reply here (busy day/quick reply from mobile, so bound to be incorrect): I think I read there were some issues with routers receiving packers via rtr with a host part that is non-zero.
This pr fixes the 'prefix length invalid, causing a router to have issues' case but it may be good to double check that the parsing does make sure that the host part is zero. I think rejecting the file is likely better then masking the host part to zero.
To follow up on this: I checked the packets sent after a SLURM file changes that containers a prefix where the host part is non-zero. Stayrtr sends the correct prefix if the host-part is non-zero in the json:
...
"prefixAssertions": [
...
{
"asn": 65002,
"prefix": "10.2.6.128/24",
"maxPrefixLength": 26
}
]
...