bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
91 stars 13 forks source link

Add proper support for RFC 8210 (BGPSEC) #57

Closed job closed 1 year ago

job commented 2 years ago

I think RFC 8210 section 6 was implemented, but Router Keys are not yet picked up from the JSON and converted into RTR PDUs (Section 5.10). An example Router Key is available under the RIPE TA. The pubkey field contains the SPKI in base64 encoded form.

benjojo commented 1 year ago

Basic POC written:


commit d44a5d5aefe129f54aacbd88efdac6da01cda8a9 (HEAD -> bgpsec-poc-bad, origin/bgpsec-poc-bad) Author: Ben Cartwright-Cox ben@benjojo.co.uk Date: Tue Feb 21 18:30:41 2023 +0000

[DO NOT MERGE] Proof Of Concept BGPSec support

Tag: https://github.com/bgp/stayrtr/issues/57

This is not a good patch, however it does work.

What I will do is instead of merging this patch, I will write a new
one based on what I have learned on writing this one.

Most critically. I will not do what I have done here, and extend
bgpsec keys as it's own family of things since VRPManager.

Since when we do ASPA, that will add even round of things to VRPManager.

So instead I will make VRPManager a thing that serves generic things
rather than just VRPs. Make VRPs a thing, BGPSecKeys and ASPA
benjojo commented 1 year ago

Last bit is to add BGPsec support to rtrmon

ties commented 1 year ago

Probably best if rtrmon can use the same data structures?

It is now completely separate and that leads to extra work for everything that is added.

On Tue, Feb 21, 2023, 23:17 Ben Cox @.***> wrote:

Last bit is to add BGPsec support to rtrmon

— Reply to this email directly, view it on GitHub https://github.com/bgp/stayrtr/issues/57#issuecomment-1439162360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQTET2TDGVGPJP7W7VOILWYU5H7ANCNFSM5JGYA5QA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

benjojo commented 1 year ago

It kinda already does use as much as possible, since RTRMon has the compare feature the needs for rtrmon are quite different to the rest of the tools

benjojo commented 1 year ago

BGPsec support is in master branch