bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
91 stars 13 forks source link

Avoid false positives in rtrmon when VRPs are removed #72

Closed erikrozendaal closed 1 year ago

erikrozendaal commented 1 year ago

Track visibility of VRPs on both sides and only consider them different when the visibility does not match based on the visibility thresholds.

Also update the results even when the sources have not been modified, since the thresholds may have changed in the meantime as time passes.

ties commented 1 year ago

It feels like we already capture Visible with FirstSeen and LastSeen and that Visible is implicit, but my initial implementation definitely did not do this correctly - which caused alerts for us, sometimes.

job commented 1 year ago

Thank you for your time and contributions @erikrozendaal and @ties