Implement draft-ietf-sidrops-8210bis-10

[benjojo]

commit e98648f8b2aadb79354e29e5c3feb94a41e6eea4 (HEAD -> draft-ietf-sidrops-8210bis-10, origin/draft-ietf-sidrops-8210bis-10) Author: Ben Cartwright-Cox ben@benjojo.co.uk Date: Wed Feb 22 17:36:06 2023 +0000

Implement draft-ietf-sidrops-8210bis-10 ROA PDU Race Minimization

It will now sort entries before they go out, Sorted by:

Largest CIDR > Largest Max Length > IP address

commit 187410d9b6f2b03b7a65fef8198571683c02dd6f Author: Ben Cartwright-Cox ben@benjojo.co.uk Date: Wed Feb 22 17:18:46 2023 +0000

Implment ASPA as defined in draft-ietf-sidrops-8210bis-10

Tag: https://github.com/bgp/stayrtr/issues/79

commit 3b73956a9c3b3401d9db200b6144134944f0b6f6 Author: Ben Cartwright-Cox ben@benjojo.co.uk Date: Wed Feb 22 15:17:26 2023 +0000

Add PDU encode/decode support for ASPA

[benjojo]

@job Looking for a sanity check on this sorting logic.

I've attached a pcap that shows the ordering that it now does:

stayrtr-pull88.pcapng.zip

[job]

looks good to me

[benjojo]

I'd like to avoid having the default version 2 being a tied to a draft of what V2 is going to look like.

When it gets adopted and everything still matches then it's fine (IMHO) to switch the default.

I know it's unlikely it's going to change, but I've been bitten by software doing this before ;)

On Wed, 22 Feb 2023, 18:06 Job Snijders, @.***> wrote:

looks good to me

— Reply to this email directly, view it on GitHub https://github.com/bgp/stayrtr/pull/88#issuecomment-1440526754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALPK4SJN6FJYHOBHXGHXALWYZITRANCNFSM6AAAAAAVEUDFWA . You are receiving this because you authored the thread.Message ID: @.***>

[job]

It's been adopted, and approved by IESG for publication; draft-ietf-sidrops-8210bis is in the RFC Editor queue (see https://www.rfc-editor.org/current_queue.php and search for 8210)... so apart from spelling errors, its not going to change

[job]

perhaps makes sense to also have a -disable.aspa CLI option?