search

bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
85 stars 13 forks source link

Build with stable and specified go version #94

Closed ties closed 1 year ago

ties commented 1 year ago

Finally. Those action things are confusing.

My idea was to build with the latest stable version (= probably what 1.19^'/1.<any> resolves to) as well as with the version we specify in go.mod.

Are there any reasons to move to a more recent go version? If we move to 1.18 we could use generics.

benjojo commented 1 year ago

If we move to 1.18 we could use generics

Do we need generics?

In general keeping to the lowest version possible (within reason ofc) helps distros build things

ties commented 1 year ago

Do we need generics?

Could probably be added in a few places. I did not feel the need yet.

In general keeping to the lowest version possible (within reason ofc) helps distros build things

Definitely. Otherwise I would have updated to $latest for both builds. I'll merge this - I think that building with the latest compiler for warnings/etc is good, while also being sure that it builds with the version mentioned in go.mod.