pytest plugin? - Githubissues

bgr / PyQt5_modeltest

PyQt5 port of modeltest.py

GNU General Public License v2.0

7 stars 3 forks source link

pytest plugin? #3

Open The-Compiler opened 9 years ago

The-Compiler commented 9 years ago

I'd like to use PyQt5_modeltest in my project and integrate it in its testsuite which uses py.test to run its tests.

Since this might also be useful for others, I can think of the following possibilites:

I just copy the code and adjust it to be a pytest fixture (i.e. available for tests). Easiest for me, but then we have two code bases.
I depend on this for my tests and write some code so it's usable via pytest - this would mean a release on PyPI would be appreciated. This is the approach I prefer currently, as I don't want to put too much time into this.
Adding a pytest plugin to this repository, adjusting modeltest.py as needed (but making sure it still works standalone) and releasing the plugin on PyPI as pytest-qt-modeltest or so.
Adding the code/functionality to pytest-qt if @nicoddemus agrees - I guess external dependencies are rather bad there - so it would mean copying the (adjusted) code. It also probably should be PyQt4/PySide compatible for that.

nicoddemus commented 9 years ago

Hi @The-Compiler, thanks for bringing this project to my attention.

I depend on this for my tests and write some code so it's usable via pytest - this would mean a release on PyPI would be appreciated.

Certainly this would be a first step.

Adding the code/functionality to pytest-qt

I'm willing to do that, but I would prefer for this to be an optional pytest-qt dependency instead of bundling/vendoring PyQt5_modeltest. For example, if an user pip install PyQt5_modeltest, then pytest-qt can provide a fixture or some other means of using it to test models. This approach would make it possible for PyQt5_modeltest to support PyQt5 only, if @bgr is not willing to support other Qt versions.

nicoddemus commented 9 years ago

Oh, I just noticed something:pytest-qt LGPL license is not compatible with PyQt5_modeltest GPL, so I'm not sure pytest-qt can use PyQt5_modeltest even as an optional dependency, can it?

The-Compiler commented 9 years ago

PyQt5_modeltest is licensed under GPLv2 (v2 only?), pytest-qt under LGPLv3 (v3 only?) - according to this compability matrix in the GPL FAQ that exact combination won't work... (if pytest-qt was LGPLv2 or PyQt5_modeltest was GPLv2 or newer, it seems it would have worked) :cry:

Software licenses are complicated... Hey, this probably means I can't even use this in qutebrowser as a testing dependency?!

The-Compiler commented 9 years ago

The current C++ version by Qt is licensed under LGPL2.1/LGPL3/GPL3 - I'm tempted to just re-port that to Python...