bgr / mingus

Automatically exported from code.google.com/p/mingus
GNU General Public License v3.0
1 stars 1 forks source link

mingus.extra.StringTuning should be more robust #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
from mingus.extra import tunings; from mingus.containers import 
NoteContainer
tuning = tunings.get_tuning("Guitar", "standard", 6, 1)
print "\n".join(repr(chord) for chord in 
tuning.find_chord_fingering(NoteContainer().from_chord("Am"))

What is the expected output? What do you see instead?
I expect to be able to choose the maximum amount of fingers to use in 
find_chord_fingering, as a positional or keyword argument, whose value 
defaults at 4. For example, the fingering [0, 0, 0, 0, 0, 0] uses 0 
fingers, while [0, 2, 2, 1, 0, 0] requires 3. Some fingerings in the output 
require 6 fingers, like [17, 15, 14, 17, 17, 17], which is impossible to 
play with one hand.

What version of the product are you using? On what operating system?
I am using mingus 0.4.2.3 on Ubuntu 10.04 Alpha 3.

Please provide any additional information below.
Attached is fingers.py which includes fingers(), which will determine the 
number of fingers a fingering requires. I would recommend adding the 
utility function distance() that will return the distance of a fingering, 
related to max_distance in find_chord_fingering().

Original issue reported on code.google.com by min%dvir...@gtempaccount.com on 14 Mar 2010 at 3:40

Attachments:

GoogleCodeExporter commented 9 years ago
Hi MindVirus, 
Thanks for the patch, I'll try to incorporate this as soon as I have some time.
Best regards,
Bart. 

Original comment by Rhijnauwen@gmail.com on 15 Mar 2010 at 4:14

GoogleCodeExporter commented 9 years ago
This issue was closed by revision f0ff8c8bd3e4.

Original comment by carlo.stemberger@gmail.com on 19 May 2011 at 12:36