search

bgr / mingus

Automatically exported from code.google.com/p/mingus
GNU General Public License v3.0
1 stars 1 forks source link

Support for Key Signatures #90

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The current MidiFileIn does not handle Key Signature changes (and gives a
Unexpected meta event for Text events). This patch fixes the former by
changing the key to the appropriate value, and setting the current bars key
to the same. It just adds a 'pass' for the latter.

I hope you find this useful - Mingus has been a god-send for me in my project.

Original issue reported on code.google.com by arunchag...@gmail.com on 17 Nov 2009 at 11:17

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi, thanks for the patch! It looks very useful, since the MidiFileIn module 
could do
with some work. The only problem is that you have attached a git patch, which 
our
subversion repository can't be brought to understand as far as I know. Could 
you make
the patch against the current trunk with svn's diff or the regular diff tool 
instead?
Thanks.
Best regards,
Bart Spaans

Original comment by Rhijnauwen@gmail.com on 18 Nov 2009 at 8:05

GoogleCodeExporter commented 9 years ago 
Hey,
PFA, the svn diff generated patch.

Cheers,
Arun.

Original comment by arunchag...@gmail.com on 19 Nov 2009 at 11:43

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r574.

Original comment by Rhijnauwen@gmail.com on 19 Nov 2009 at 2:48

GoogleCodeExporter commented 9 years ago 
Hey Arun, 
Thanks for your patch! It's much appreciated. I've applied it to the code-base 
and it
will be available in the next release (0.4.3).  Let me know if you have any more
code/ideas you wish to add, because then I could give you commit access.
Best regards, 
Bart Spaans

Original comment by Rhijnauwen@gmail.com on 19 Nov 2009 at 3:14

GoogleCodeExporter commented 9 years ago 
Hello Bart,
    Thank you very much for the offer. I do have a few other issues that I would like
to fix - there is a nasty bug in the scales package that does not let me give 
it a
note (I believe it has to do with the string matching). I'm not very well 
versed in
music (which is why Mingus is such a god-send), but I'd love to help out in 
fixing
bugs, etc.

Cheers,
Arun Chaganty

Original comment by arunchag...@gmail.com on 22 Nov 2009 at 8:06

GoogleCodeExporter commented 9 years ago 
Hi Arun, 
Glad to hear you made good use of the project :) 
I have added you to the list of project committers, so you're welcome to work 
on some
things you like or need. If you would like to change or add something just open
another issue so that it can been seen by other people and so that we can 
discuss
what could be done. This is just to coordinate the commit process a bit and to
prevent unnecessary work and merges, which are painful in SVN. Let me know if 
you
have any questions about any of this, since we're still lacking a proper 
contributors
guide ;) 
Anyway, welcome on board :)

-Bart

Original comment by Rhijnauwen@gmail.com on 24 Nov 2009 at 3:38

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r579.

Original comment by arunchag...@gmail.com on 26 Nov 2009 at 2:23