search

bgrabitmap / bgracontrols

🆗 BGRA Controls is a set of graphical UI elements that you can use with Lazarus LCL applications.
https://bgrabitmap.github.io/bgracontrols/
189 stars 32 forks source link

TBCComboBox in macOS ShowModal issues #174

Closed lainz closed 6 months ago

lainz commented 6 months ago

-Test project: testcombobox.zip -Seems that there's a bug with macOS and ShowModal (in fixes-fixes lazarus and fpc) that prevents of showing the items of the combobox in front of a modal form.

@circular17 can you confirm this bug, I don't have macOS to test.. if you have only release test anyway, or if you have trunk no problem. But this have been replicated in fixes-fixes with fpcupdeluxe.

lainz commented 6 months ago

Seems that I missed one point, the bug is not in fixes-fixes but in trunk (master of git)... so if you have master please test, if you have releases please test too so we can know if it's a bug in bgracontrols or in the LCL...

lainz commented 6 months ago

Attached a fix that's tested on macOS, but not on other OS's. bccombobox.zip

lainz commented 6 months ago

Using ShowModal instead of Visible := True solves the problem, but I changed the unit a bit more... so better if it's well tested again...

circular17 commented 6 months ago

Hi Leandro,

Sorry for the late reply. I've updated the test_bccombobox example to include your idea to test as modal. On Windows 11, it all works fine.

I've tried it on MacOS with Lazarus 3.0 (with FPC 3.2.2) and it seems to be working fine.

Would you like me to try something else?

Regards

lainz commented 6 months ago

Thanks for testing =)

Nothing more, I think is solved.