Use sublime URL opening code

bgreenlee / sublime-github

Sublime Text 2/3 plugin that provides a number of useful commands for GitHub.

MIT License

455 stars 98 forks source link

Use sublime URL opening code #110

Closed SCdF closed 7 years ago

SCdF commented 7 years ago

Solves a bug (that may just be for me / due to my python configuration) where urls opened via webbrowser were opening in a different browser than the OS default browser. Sublime's URL opening code works correctly.

SCdF commented 7 years ago

Tiny PR for you @bgreenlee, just changes the URL opening code from a python library to a Sublime one. Fixed an issue for me where Python wanted to open all URLs in Firefox for some reason instead of Chrome (my OS default).

bgreenlee commented 7 years ago

Thanks for this, but looks like this was a bug in Sublime that was fixed (see #111). I'd like to err on the side of not changing it and relying on that fix. Feel free to reopen if you disagree.

SCdF commented 7 years ago

Agreed.