search

bgreenlee / sublime-github

Sublime Text 2/3 plugin that provides a number of useful commands for GitHub.
MIT License
456 stars 92 forks source link

Interferes with "find next" and "find previous" keyboard commands #45

Closed TrevorBurnham closed 11 years ago

TrevorBurnham commented 11 years ago

For some reason, when I have this plugin enabled, I have to press ⌘G twice in order to trigger the "Find Next" command after an initial find. Clicking "Find Next" in the "Find" menu works fine.

bgreenlee commented 11 years ago

That's because of these keyboard shortcuts: https://github.com/bgreenlee/sublime-github/blob/master/Default%20(OSX).sublime-keymap

You can fix this by going to Preferences -> Key Bindings - User and resetting them. E.g.:

[ ...
    { "keys": ["super+g"], "command": "find_next" },
    { "keys": ["ctrl+super+g", "ctrl+super+n"], "command": "public_gist_from_selection" },
    { "keys": ["ctrl+super+g", "ctrl+super+p", "ctrl+super+n"], "command": "private_gist_from_selection" },
    { "keys": ["ctrl+super+g", "ctrl+super+o"], "command": "open_gist_in_editor" },
    { "keys": ["ctrl+super+g", "ctrl+super+c"], "command": "open_gist_url" }
]

Arguably something like the above should be the default so as not to interfere with a core function, although changing them now might mess some people up (like @renz45, who added them). Probably worth it, though--it is pretty hard to discover. At the very least I'll add something to the README.

renz45 commented 11 years ago

Looking back on that, it was probably a bad choice to bind that key, I agree that it should probably be removed from the default.