Urls are not generated properly for submodules

bgreenlee / sublime-github

Sublime Text 2/3 plugin that provides a number of useful commands for GitHub.

MIT License

456 stars 92 forks source link

Urls are not generated properly for submodules #60

Closed ksemel closed 10 years ago

ksemel commented 10 years ago

Fetch the toplevel directory of the repo from git so urls are handled properly when checking history for submodules

ksemel commented 10 years ago

I have several projects using submodules and found the urls generated were the full system path to the file rather than the relative path when in a submodule directory.

The bug fix fetches the toplevel directory as reported by "git rev-parse --show-toplevel" to strip the extra directories from the absolute file path before sending the url.

bgreenlee commented 10 years ago

Awesome! Thank you for the PR.