search

bgreenwell / RBitmoji

An R wrapper to the overly complicated Bitmoji API 😱
24 stars 5 forks source link

new function get_id() #2

Closed j-c-o-l-l-i-n-s closed 6 years ago

bgreenwell commented 6 years ago

Awesome PR! Once the rest of the functionality is there, I'll start rewriting the functions (plot_comic(), etc. were just place holders to show POC). Also gonna transfer this repo to koalaverse!

j-c-o-l-l-i-n-s commented 6 years ago

@bgreenwell in the README/To Do you list

  1. Switch to using httr
  2. Use JSON file to look up comic_id via keyword tags

For 3. are you looking to replace the use of magick in get_comic()? and for 4. you are already using grepl to search data-raw/comics.json. What functionality are you hoping to add?

I might be able to put some time towards this... Can't go wrong with overuse of Bitmoji

bgreenwell commented 6 years ago

No, in fact i'd like to remove the dependency on magick since it can be troublesome to install on Macs. Basically, it provided an easy way to show POC so I used it! Maybe it is the best answer?

Not sure what I was thinking with 4, so doesn't look like that's an issue anymore.

My biggest concern was figuring out the ID!! So, we can rewrite the package to be more user friendly now...