Move class "explain" to front

bgreenwell / fastshap

Fast approximate Shapley values in R

https://bgreenwell.github.io/fastshap/

115 stars 18 forks source link

Move class "explain" to front #46

Closed mayer79 closed 2 years ago

mayer79 commented 2 years ago

Small suggestion: move class "explain" in front of the other classes of the resulting explainer object. This makes it easier to write methods for "explain" objects. Needs to be tested though.

bgreenwell commented 2 years ago

Thanks @mayer79! Will review/merge once I’m back from vacation!!

bgreenwell commented 2 years ago

@mayer79 would you mind adding this tweak to the relevant tests that failed because they check for the old class structure?