bgreenwell / fastshap

Fast approximate Shapley values in R
https://bgreenwell.github.io/fastshap/
112 stars 18 forks source link

Add missing shap_only #59

Closed mayer79 closed 1 year ago

mayer79 commented 1 year ago

I think there are two explain methods, where shap_only is not passed to the default method.

bgreenwell commented 1 year ago

Ahh, thanks @mayer79, I had just caught this (and a few other things actually) and it should be fixed in the main branch.

mayer79 commented 1 year ago

Then the main branches of both projects are settled. We can make an independent check each, then shapviz goes to CRAN!

bgreenwell commented 1 year ago

I'm working on another package that uses fastshap at the moment, so will likely wait and submit both to CRAN in a couple weeks.