bgregos / foreground

Simple Android personal task manager with Taskwarrior integration
Apache License 2.0
253 stars 15 forks source link

task detail: add Save button #177

Closed skrobul closed 7 months ago

skrobul commented 8 months ago

This PR adds an explicit "Save" button on the task detail screen. I have added this button mostly to scratch my own itch that bothered me for a long time, but later on I found that others also find clicking "Back" button to save non-intuitive and disrupting to the workflow. My main issue is that when adding new task, my eyes start at the top, then follow all fields to the bottom, where I expect some sort of confirmation button.

Please see #174 for the discussion about it.

image

bgregos commented 8 months ago

Thanks for the PR. This should make things more clear for users, so I'm good from a UI perspective. I do have concerns as to what happens to that row on devices with small screens- I'll check on that before merging.

bgregos commented 7 months ago

Looks good, thanks for your contribution! I'll get this released to the stores soon.