search

bgrimstad / splinter

Library for multivariate function approximation with splines (B-spline, P-spline, and more) with interfaces to C++, C, Python and MATLAB
Mozilla Public License 2.0
418 stars 115 forks source link

modified bssplinebasis to remove the inconsistency #108

Closed giovastabile closed 6 years ago

giovastabile commented 6 years ago

modified bssplinebasis to remove the inconsistency and to make the library compiling also with newer versions of Eigen (tested with 3.3.5).

bgrimstad commented 6 years ago

I believe that this already has been fixed in the develop branch. Please confirm.

Also note that we accept merge requests to the develop branch only (although exceptions have been made). If you find that the issue above has not been fixed, please prepare another pull request to the develop branch.

Thank you for your help!

giovastabile commented 6 years ago

Yes I checked and the issue has already been solved thank you. I will switch to the development branch and I'll let you know if I notice additional issues.

Best,

Giovanni

2018-07-26 14:02 GMT+02:00 Bjarne Grimstad notifications@github.com:

I believe that this already has been fixed in the develop branch. Please confirm.

Also note that we accept merge requests to the develop branch only (although exceptions have been made). If you find that the issue above has not been fixed, please prepare another pull request to the develop branch.

Thank you for your help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bgrimstad/splinter/pull/108#issuecomment-408073842, or mute the thread https://github.com/notifications/unsubscribe-auth/AEwCkkg_h8GzEVvD4jVzGM-WHRay3JJtks5uKa_XgaJpZM4Vgajh .

-- Giovanni Stabile Via Baruffi, 7 - 50023 - Florence, Italy mobile: +39 333 5273567 / e-m@il: giovanni.stabile87@gmail.com

bgrimstad commented 6 years ago

Very good. Appreciate the feedback.