search

bgrimstad / splinter

Library for multivariate function approximation with splines (B-spline, P-spline, and more) with interfaces to C++, C, Python and MATLAB
Mozilla Public License 2.0
418 stars 115 forks source link

A coding error in bsplinebasis.cpp line 118 when I try the lastest Eigen #116

Open QinjieXiao opened 5 years ago

QinjieXiao commented 5 years ago

A coding error in bsplinebasis.cpp line 122 ：for (SparseMatrix::InnerIterator it(Ji,k); it; ++it)

When I try the lastest Eigen, it output the following error:

error: calling a private constructor of class 'Eigen::SparseCompressedBase<Eigen::SparseMatrix<double, 0, int>

::InnerIterator' for (SparseMatrix::InnerIterator it(Ji,k); it; ++it) ^ /Users/jerry/Documents/articles/Faces/mycode/shadow_face/3rdparty/src/splinter/thirdparty/Eigen/Eigen/src/SparseCore/SparseCompressedBase.h:210:26: note: declared private here template InnerIterator(const SparseMatrixBase&, Ind...

I think it shoud be: for (SparseVector::InnerIterator it(Ji,k); it; ++it), because the type of Ji is SparseVector. And it works