search

bgrimstad / splinter

Library for multivariate function approximation with splines (B-spline, P-spline, and more) with interfaces to C++, C, Python and MATLAB
Mozilla Public License 2.0
419 stars 115 forks source link

Inconsistent correspondence between sample points and weights #95

Closed bgrimstad closed 6 years ago

bgrimstad commented 6 years ago

Sample points are ordered by DataTable according to coordinate values, while the order of the weights (stored in a std::vector) is preserved. This will cause an inconsistent correspondence between weights and sample points when the sample points are added in a different order than they are stored by DataTable.

bgrimstad commented 6 years ago

We should consider reworking DataTable to store samples in the order that they are given. The ordering on coordinate values is legacy and not required anymore.

bgrimstad commented 6 years ago

Reworked DataTable class pushed in d45cf597536203fa841ec5486b5a0e5e5017c5f2. Samples are now stored in a vector without any ordering (samples are stored in the same sequence as they are added). The new DataTable is compatible with the old json format. Some unused functionality has been removed to ease maintenance.