search

bgrins / ExpandingTextareas

jQuery plugin for elegant expanding textareas
http://bgrins.github.com/ExpandingTextareas/
MIT License
261 stars 73 forks source link

Max height #42

Closed domchristie closed 10 years ago

domchristie commented 10 years ago

This pulls in @Serhioromano’s commits from #40, and fixes tests re: outerHeight(), and [wrap=off]

bgrins commented 10 years ago

Sounds good. FYI, I will not have a chance to land this until next week.

On Mar 8, 2014, at 12:36 PM, Dom Christie notifications@github.com wrote:

This pulls in @Serhioromano’s commits from #40, and fixes tests re: outerHeight(), and [wrap=off]

You can merge this Pull Request by running

git pull https://github.com/domchristie/ExpandingTextareas max-height Or view, comment on, or merge it at:

https://github.com/bgrins/ExpandingTextareas/pull/42

Commit Summary

Take max height from text area css property. Delete extra lines. Moved styles to _copyTextareaStylesToClone delete .expanding-clone class from examples. Change text in test test modifield Change text in documentation. Fix max-height test Fix text wrap test File Changes

M expanding.js (6) M index.html (10) M test/expanding_test.js (13) Patch Links:

https://github.com/bgrins/ExpandingTextareas/pull/42.patch https://github.com/bgrins/ExpandingTextareas/pull/42.diff — Reply to this email directly or view it on GitHub.

domchristie commented 10 years ago

No problem.

bgrins commented 10 years ago

Merged and tagged 0.1.1

domchristie commented 10 years ago

Thanks.