Non-jQuery version

[domchristie]

@bgrins I have been working on a version of this idea which does not depend on jQuery. It takes quite a different approach, but uses some of the ideas present in this repo.

Would you be happy for me to start a new repo with this new code and publish it to NPM?

[bgrins]

Cool, it's up to you how you want to proceed - if it has similar features / browser support I'd wouldn't be opposed to taking the changes into master on this repo but don't have any problem if you'd rather start it as a new project. I'm curious - what's the approach for the new version?

[domchristie]

Thanks!

I'm curious - what's the approach for the new version?

A summary of the differences:

• The API is new Expanding(textarea)
• It separates the wrapper, textarea, and clone into separate classes
• It uses ES2015 modules for each class, and is compiled into a single file with Rollup. (The source code is still written in ES5 to keep the build process simple and minimise the impacts of transpilation.)
• Changes the update event to expanding:update as custom, native, namespaced events cannot be bound in jQuery (i.e. it is not possible to do: $(document).on('update.expanding'))
• It uses mocha + chai for running tests/assertions as I find useful the describe / context / it approach

• The file structure is as follows:

  dist/
  expanding.js 
  src/
  expanding.js
  helpers.js
  textarea-clone.js
  textarea.js
  test/
  lib/
   chai.js
   mocha.css
   mocha.js
   sinon.js
  expanding-test.js
  index.html
  integration-test.js
  textarea-clone-test.js
  textarea-test.js

I started writing this with a pull request in mind, but wonder if the diff might be a little difficult to review?

[bgrins]

The diff might be hard to review but feel free to send it over and we'll see what it ends up looking like.

What do you think about keeping a jQuery plugin registration that just calls out to new Expanding(textarea) to keep backwards compat?

[domchristie]

OK, cool. I'll try and get something together that makes a bit more sense, perhaps by rewriting some of the internal methods to use vanilla JS/DOM.

Re: keeping the jQuery plugin, yeh sounds good, and it is kind of what we're doing already. There is a bit of jQuery code to prevent the plugin from being reinitialised, but it should be fairly straightforward.

[domchristie]

Closed by https://github.com/bgrins/ExpandingTextareas/pull/64