bgrins / ExpandingTextareas

jQuery plugin for elegant expanding textareas
http://bgrins.github.com/ExpandingTextareas/
MIT License
261 stars 73 forks source link

is this package on NPM? #69

Closed jonknapp closed 7 years ago

jonknapp commented 7 years ago

It appears that the package expanding-textareas cannot be found on NPM, though it's referenced in the README. Would the maintainer be able to push at least the latest version to NPM?

You'll probably have to checkout the tagged release, then do a publish to NPM:

git checkout 0.3.0
npm publish --tag 0.3.0
jonknapp commented 7 years ago

One thing to watch is that I believe it nabs the version from the package.json file which may or may not refer to the tagged version on Github.

bgrins commented 7 years ago

Thanks for the heads up, I just published. Although I believe you are right and it published as 1.0 instead of the latest tag, so I'll need to re-tag a minor version update and publish again.

@domchristie hope you were ready to call this "1.0" - I'm assuming you are since that's the version # we landed in the package.json in the refactor

bgrins commented 7 years ago

OK, 1.0.1 is published at https://www.npmjs.com/package/expanding-textareas.

@domchristie what do you want to mark as the 'main' file in package.json? dist/expanding.js or dist/expanding.jquery.js?

domchristie commented 7 years ago

@domchristie hope you were ready to call this "1.0" - I'm assuming you are since that's the version # we landed in the package.json in the refactor

👍 Yep, sounds good to me

@domchristie what do you want to mark as the 'main' file in package.json? dist/expanding.js or dist/expanding.jquery.js?

dist/expanding.js works nicely IMO

kcivey commented 7 years ago

Bower won't install it for me because the bower.json file is invalid:

bower                     invalid-meta for:/var/www/Posse/bower.json
bower                     invalid-meta The "name" is recommended to be lowercase, can contain digits, dots, dashes
bower expanding-textareas#1.0.1       not-cached https://github.com/bgrins/ExpandingTextareas.git#1.0.1
bower expanding-textareas#1.0.1          resolve https://github.com/bgrins/ExpandingTextareas.git#1.0.1
bower expanding-textareas#1.0.1         download https://github.com/bgrins/ExpandingTextareas/archive/1.0.1.tar.gz
bower expanding-textareas#1.0.1          extract archive.tar.gz
bower expanding-textareas#1.0.1       EMALFORMED Failed to read /tmp/keith/bower/481a17a3d5ed933e525e6b5ab984adac-8467-H718Fv/bower.json

Additional error details:
Unexpected token ]

The problem is the extra comma after "node" on line 14.

bgrins commented 7 years ago

OK, bower and npm should be working as 1.0.2: https://www.npmjs.com/package/expanding-textareas