search

bgrins / TinyColor

Fast, small color manipulation and conversion for JavaScript
https://bgrins.github.io/TinyColor/
MIT License
5.08k stars 438 forks source link

is this project still maintained? #151

Open EmmaRamirez opened 7 years ago

EmmaRamirez commented 7 years ago

I noticed that this project hasn't been updated in over six months, and I was wondering if perhaps this project wasn't being actively maintained anymore?

(Sorry to intrude, I just saw some PRs that would be integral to my usage of TinyColor that haven't been accepted in several months).

neuropass commented 6 years ago

yeah there tons of opened issue and pull request and no answer? Please @bgrins let people know if you can't currently look into this? At least we know what to do for project where this was implemented... Thanks again!

scttcper commented 6 years ago

I needed proper tree shaking and other breaking changes. Merged in a bunch of the useful open PR's and added a more functional random. Summary of changes at the top. Published as a scoped package

https://github.com/TypeCtrl/tinycolor

bgrins commented 6 years ago

Sorry for not responding - I've had really limited availability lately so haven't had time to keep up. I'd be happy to have help maintaining the project if anyone is willing.

@scttcper - do you have a list of which PRs / changes you've made?

bgrins commented 6 years ago

@scttcper - do you have a list of which PRs / changes you've made?

Nevermind - I see the list at https://github.com/TypeCtrl/tinycolor#changes-from-tinycolor2. Are you interested in porting these back?

Looking at the list I guess the biggest change is the language change to typescript. That was in order to get tree shaking?

Also, I'd prefer to still keep a home page at http://bgrins.github.io/TinyColor/ beyond just docs (as in https://typectrl.github.io/tinycolor/). Those docs look nice but maybe they could get built into a subdirectory like http://bgrins.github.io/TinyColor/docs/ or similar?

scttcper commented 6 years ago

@bgrins thanks for checking it out. I am interested for sure. Chose typescript because its what I like to work with and it is what creates those API docs. People show up asking for types eventually or they make their own like @types/tinycolor2

The tree shaking comes from exporting a "main" and a "module" in the package.json. more info So there's a build step to create them both (on top of putting the typescript into js).

I'd also prefer to keep the home page the same as its what brought me to this project. Maybe give me a day or two, that structure makes sense.

scttcper commented 6 years ago

Its back to the og demo https://typectrl.github.io/tinycolor/ and the "typedoc" generated api docs are at /docs

bgrins commented 6 years ago

Its back to the og demo https://typectrl.github.io/tinycolor/ and the "typedoc" generated api docs are at /docs

OK, great! I haven't been able to look through all the changes but from initial review it seems pretty similar to the current source. If the test coverage is basically the same I'd be pretty happy with getting it landed and doing a major version bump for the API changes. Can you send a PR with your changes?