search

bgrins / TinyColor

Fast, small color manipulation and conversion for JavaScript
https://bgrins.github.io/TinyColor/
MIT License
5.05k stars 438 forks source link

Updated grunt-contrib-qunit version to 3.0.1 to replace phantomjs dependency with chromium puppeteer #198

Closed ossdev07 closed 3 years ago

ossdev07 commented 5 years ago

Updated grunt-contrib-qunit version from 0.7.0 to 3.0.1 to replace phantomjs dependency with chromium puppeteer as phantomjs is currently unmaintained. Output after update:

puppeteer@1.7.0 install /TinyColor/node_modules/puppeteer node install.js

Downloading Chromium r579032 - 102.3 Mb [====================] 100% 0.0s Chromium downloaded to /TinyColor/node_modules/puppeteer/.local-chromium/linux-579032 npm notice created a lockfile as package-lock.json. You should commit this file. added 45 packages from 29 contributors, removed 3 packages and audited 192 packages in 20.434s found 20 vulnerabilities (12 low, 8 high) run npm audit fix to fix them, or npm audit for details

rhenwood-arm commented 5 years ago

I would like to see this landed. @bgrins can you provide feedback on this PR?

ossdev07 commented 4 years ago

@bgrins ,

Please have a look at this PR. Please provide feedback if any changes required.

ossdev07 commented 4 years ago

@bgrins Updated grunt-contrib-qunit version to latest in package.json as the latest puppeteer version has support for aarch64 platform. Updated travis.yml to use the latest nodejs versions as puppeteer doesn't support older versions.

bgrins commented 3 years ago

Thanks for the PR (and sorry for the long delay)