Closed marcandre closed 10 years ago
Will you please add a few checks in the "TinyColor initialization" section of the test dealing with creating the object with the new
keyword and passing in an existing tinycolor instance as the first parameter to the constructor?
Good point. Tests added.
Excellent, thanks! I've now also updated the test suite a bit and added a hook to travis ci: https://travis-ci.org/bgrins/TinyColor.
Is there a good reason why
TinyColor
doesn't return objects with functions based on a prototype? This makes the memory footprint bigger that it needs to be, and also makes it impossible to monkey patch behaviour. Here's a PR in case you'd like it to work.Note: there was one test relying on 'alpha' instead of
getAlpha()
. I presume that was not intended?