search

bgrins / console-output-experiment

1 stars 2 forks source link

Repeat test #39

Closed linclark closed 8 years ago

linclark commented 8 years ago

Fixes #37 The last test currently fails because we seem to count different falsy values as repeats.

bgrins commented 8 years ago

The last test currently fails because we seem to count different falsy values as repeats.

This looks like an issue with JSON.stringify - JSON.stringify({ args: [undefined] }) == JSON.stringify({ args: [null] }). So I guess we'll need to come up with a better way to store repeat IDs / compare across repeat IDs. If we stick with repeatID as a concept, we could test this behavior directly using the getRepeatId function.

We had a similar issue in Bug 1218089 which was resolved by https://hg.mozilla.org/mozilla-central/rev/1b290ea60421, although it's using JSON.stringify so I don't know why that works but this doesn't.

bgrins commented 8 years ago

Regardless of what we do with repeating messages, this looks like some really nice additions / organization so I'd say land it

linclark commented 8 years ago

Landed, thanks for the review :)