search

bgrins / devtools-snippets

A collection of helpful snippets to use inside of browser devtools
http://bgrins.github.io/devtools-snippets/
2.96k stars 370 forks source link

Add hex color values to snippets/allcolors.js #48

Closed darryldalton closed 10 years ago

darryldalton commented 10 years ago

In addition to adding hex color values you can also exclude elements that have a border color with a zero width.

bgrins commented 10 years ago

I'm curious, what is the case where the zero width borders are causing problems? I'm thinking computed border color would always be set to text color unless if it was manually set.

darryldalton commented 10 years ago

In my projects I often have css properties that contain a border: 0px solid red;. I only have the boder turned on during the early stages of page layout and the boders allow my to see where my elements are lining up. The once everything is good I set the border width to zero while leaving the line there just in case I need to turn it on again at a latter point. While using your allcolors snippet I noticed it was including these 0 px border color in the list even though they don't actually appear in the page. This is why I choose to provide a way to include or exclude these values from the final list of color.

I'll be happy to remove them and only use logic in my on fork. I just thought someone else my find it useful.

Thank you for the opportunity to contribute to your project. I've been doing web dev since 1995 but this is my first venture into open/source and GitHub.

bgrins commented 10 years ago

@darryldalton sorry it took so long to merge. Thanks for the contribution!