bgrnwd / mobfot

:soccer: An unofficial Python client for the FotMob API
https://bgrnwd.com/mobfot/
MIT License
29 stars 4 forks source link

[Feature Request]: get Matches by league #16

Closed CodeModeYT closed 1 month ago

CodeModeYT commented 4 months ago

What feature would you like to see?

I’d love to see a feature like get_matches_by_league(id) (it could work just like get_matches_by_date(date))

bgrnwd commented 2 months ago

Hey @CodeModeYT , sorry it's taken a while to get back to you.

get_matches_by_league doesn't look to be an explicit endpoint on the API like get_matches_by_date is. I could return the matches key from get_league though. (e.g. https://www.fotmob.com/leagues/47/matches/premier-league) Would that work for you?

CodeModeYT commented 2 months ago

Hey @CodeModeYT , sorry it's taken a while to get back to you.

get_matches_by_league doesn't look to be an explicit endpoint on the API like get_matches_by_date is. I could return the matches key from get_league though. (e.g. https://www.fotmob.com/leagues/47/matches/premier-league) Would that work for you?

That would also work, thank you so much!

bgrnwd commented 1 month ago

@CodeModeYT 1.4.0 has the new function in it. Let me know if it was what you were looking for

CodeModeYT commented 1 month ago

@bgrnwd Looks good so far; I'll try to implement it into my app asap and get back to you after I tested it. Thank you so much!

CodeModeYT commented 1 month ago

@bgrnwd Got to test it out today; it's perfect, thank you so much!