Feature: Add season filtering into get_league

bgrnwd / mobfot

:soccer: An unofficial Python client for the FotMob API

https://bgrnwd.com/mobfot/

MIT License

32 stars 5 forks source link

Closed cosminpm closed 5 months ago

cosminpm commented 5 months ago

Add season filtering into the get_league method.

I have added these filter so we can filter by season.

bgrnwd commented 5 months ago

@cosminpm Thanks for the PR!

Looks like there are some linting errors. Mind taking care of those and then adding a test case for the new functionality?

cosminpm commented 5 months ago

@bgrnwd Yes, I will do it when I have some time, sorry for not checking the linting, my bad 😞

bgrnwd commented 5 months ago

No worries! We should also bump the patch number of VERSION in client.py

cosminpm commented 5 months ago

Hello @bgrnwd feel free to review. I added some small general improvements.

By the way I think it would be nice to have the requirements pinned for future contributions.

cosminpm commented 5 months ago

Hello @bgrnwd I forgot to update the version number, can you do it?

bgrnwd commented 5 months ago

Yep, I will do it and push a version out

EDIT: Published 🚀