search

bgrsquared / places

Looking into names of places ( http://bgrsquared.com/places/ ), based on Moritz Stefaner's http://truth-and-beauty.net/experiments/ach-ingen-zell/
http://bgrsquared.com/places/
MIT License
45 stars 6 forks source link

Rename `overpassScripts/*` to `overpassScripts/*.overpassql` #11

Closed FloEdelmann closed 1 year ago

FloEdelmann commented 1 year ago

*.overpassql is now the recommended file extension for Overpass QL: OSM Wiki: Overpass QL § File extension (Disclaimer: I added that section after some discussion.) Also, it is the most widely used extension on GitHub, see https://github.com/users/FloEdelmann/projects/2/views/2

I propose to rename all Overpass QL files in this repo to *.overpassql for consistency.

Context: GitHub's syntax highlighting engine requires that 200 repositories use the same file extension before they consider supporting that syntax and file extension: https://github.com/github/linguist/issues/5890

FloEdelmann commented 1 year ago

@chroth7 Would a pull request be accepted?

chroth7 commented 1 year ago

thanks @FloEdelmann for offering a PR into that

thing is, I haven't touched this repo for a LONG time now and it is heavily outdated... so I am guessing it could be tricky. Truth be told, I wasn't even aware that the app is still online :-)

so I am not quite sure how to continue here, if we should overhaul the whole thing, if somebody wants to take it over, ...?

happy to discuss!

chroth7 commented 1 year ago

and I am a bit scared at looking at my 8 year old code 😱

FloEdelmann commented 1 year ago

@chroth7 Since this suggestion consists only of renaming some files, the changes should be relatively easy. I created a PR: #12.

chroth7 commented 1 year ago

@FloEdelmann thanks, you are right, straightforward. As no CI/CD is linked, the impact will be small :-)