Fix removal of zip dependency in Python script.

bgruening / conda_r_skeleton_helper

Cleaning up Conda r-packages

MIT License

47 stars 32 forks source link

Fix removal of zip dependency in Python script. #30

Closed jdblischak closed 5 years ago

jdblischak commented 5 years ago

It was still using a regex from re.sub, but line.replace does not use regexes.

xref: #28, https://github.com/conda-forge/staged-recipes/pull/7209#issuecomment-445520925, https://github.com/bgruening/conda_r_skeleton_helper/commit/2cb3f05eafc18debb86541a38996dd1ee3b261bd#diff-6e38f16215ae91c11fc5c54b74c66d54L111

bgruening commented 5 years ago

This should be fixed on master, isn't it?

jdblischak commented 5 years ago

This should be fixed on master, isn't it?

@bgruening Yep!

I'm not quite sure what happened. You seem to have made the same change as I did, but GitHub showed me the diff below when I submitted the PR. And I am pretty certain there was no conflict at that time. Maybe you pushed the commit to GitHub much later than when you fixed it locally?

screenshot from 2018-12-09 19-38-11