search

bgruening / docker-galaxy

:whale::bar_chart::books: Docker Images tracking the stable Galaxy releases.
http://bgruening.github.io/docker-galaxy
MIT License
226 stars 134 forks source link

reword the security configuration #497

Closed martenson closed 5 years ago

martenson commented 5 years ago

to discourage people from passing master API key as env variable

questions:

bgruening commented 5 years ago

do you still need to unset the variables?

No.

should we include id_secret change?

Oh that's a good idea. But we probably need to explain what this secret is doing.

dannon commented 5 years ago

Should we additionally change the master API key, to be even more obvious, to something like:

master_api_key=THEDEFAULTMASTERKEYISNOTSECURE

Like we do in Galaxy?

(not necessarily in this PR, just something to think about)

bgruening commented 5 years ago

Thanks @martenson