[20.05] several bug fixes - Githubissues

bgruening / docker-galaxy

:whale::bar_chart::books: Docker Images tracking the stable Galaxy releases.

http://bgruening.github.io/docker-galaxy

MIT License

226 stars 134 forks source link

[20.05] several bug fixes #560

Closed abretaud closed 4 years ago

abretaud commented 4 years ago

So I found a few bugs in 20.05 while playing with the GGA flavor:

when the admin user gets updated (=each time install-tools is called), it hashes the password with pbkdf2 instead of sha1 as is configured in docker-galaxy-stable by default, which breaks the proftpd auth. Fixed in https://github.com/galaxyproject/ansible-galaxy-extras/commit/e47436c941c5394aa6c09632d10df371ed6bcf68
a problem with auth_conf.xml testing, fixed in https://github.com/galaxyproject/ansible-galaxy-extras/pull/243/commits/475f37f2ddf88c7592a2c9da26da929211842330
conda envs created with install-tools were owned by root instead of galaxy, fixed in https://github.com/bgruening/docker-galaxy-stable/commit/55d049090e23bc9a5667f52beccc1fc89c7ca823
there was a line of python2 code, fixed in https://github.com/galaxyproject/ansible-galaxy-extras/pull/243/commits/f1d3684ddbc1b7ea1756a237fba56c8e46cab066 and https://github.com/bgruening/docker-galaxy-stable/commit/acb93e2d9df42db8c8fc3a2c218f16d19ccbb4af

There is a chicken & egg thing for https://github.com/galaxyproject/ansible-galaxy-extras/pull/243 which is red until this PR is merged

abretaud commented 4 years ago

@bgruening do you mind if I retag the 20.05 release (=delete+recreate) or do you prefer a 20.05.1?

bgruening commented 4 years ago

I already did ... Container should be hopefully updated :)

abretaud commented 4 years ago

Awesome, I had not seen, thanks :)