search

bgruening / docker-ipython-notebook

:whale: :microscope: :books: IPython running in a docker container. This image can be used to integrate IPython into Galaxy
MIT License
17 stars 9 forks source link

Change default user #29

Closed bgruening closed 9 years ago

bgruening commented 9 years ago

fix for: https://github.com/bgruening/docker-ipython-notebook/issues/28

This PR will change the default user to the same UID and GID of the parent Galaxy Docker container. This enables installing with pip and install.package(). Moreover, I added curl as dependency so we do not need to use a python library for this (we still can if we want).

bgruening commented 9 years ago

@jmchilton do we agree to start the container as root and change with sudo to an unprivileged user after chmod everything to the galaxy-host-user?

jmchilton commented 9 years ago

Yes I am :+1: on doing that - I think that would be better.

bgruening commented 9 years ago

@jmchilton I played a little bit with this idea, but in Galaxy we are changing the user inside the container with "docker run -u %s" % (os.geteuid()). This means we are not root inside the container and can not add a new user. Is removing -u from the IE an option?

jmchilton commented 9 years ago

This is fine by me - we can make it an option on the IE implementation. Feel free to open a PR with that change or create a ticket somewhere and assign it to me.