bgruening / docker-jupyter-notebook

:whale: :microscope: :books: Jupyter running in a docker container. This image can be used to integrate Jupyter into Galaxy
MIT License
35 stars 39 forks source link

Stage additional ids as sent from the server. #17

Closed jmchilton closed 7 years ago

jmchilton commented 7 years ago

It is fine if in the future we want to think about disabling the server from sending this - but as long as the GUI elements are connected up I think we should respond to them properly.

jmchilton commented 7 years ago

I guess we also need to check if the data is already there - huh? And we should maybe try to replicate the naming pattern used when mounted as a volume? Hmm...

Updated my Galaxy PR to now set this environment variable unless the deployer indicates volumes are unavailable.

jmchilton commented 7 years ago

I redid that loop and tested - the other way was clearly suboptimal - thanks for the catch @bgruening!