search

bgruening / galaxy-ipython

:microscope::books: IPython Integration into Galaxy
MIT License
31 stars 14 forks source link

Update plugin for Galaxy Pull Request #450 #14

Closed jmchilton closed 10 years ago

jmchilton commented 10 years ago

More information on Galaxy changes here: https://bitbucket.org/galaxy/galaxy-central/pull-request/450/plugin-framework-enhancements-to-improve/commits.

Cleaner abstractions, fixing plugin to auto-generate a user's API key if it doesn't already exist, and fixes the plugin if deployed to paths other than config/plugins/visualizations.

jmchilton commented 10 years ago

... forgot the downside - only works with -central and not the August release anymore. Maybe create a -central and -stable branch of the plugin?

hexylena commented 10 years ago

My vote is not to have galaxy version dependent versions of this plugin. I'd rather wrap in try...excepts and be able to take advantage of those features when available, but fall back to what we know works.

It's exactly like the routing issue. We'd like to provide galaxy-core based solutions, but have a fallback.

bgruening commented 10 years ago

+1 for try...except in this case.

If we will have larger code changes I would rather tag a release and start developing in master. Overall this feature is for Galaxy-Pros and they can use central for the next two month or so.

jmchilton commented 10 years ago

Okay this new stuff hasn't been tested yet - I will try to find some time to do that - but this is what it might look like with try... except.