bgruening / galaxytools

:microscope::books: Galaxy Tool wrappers
MIT License
116 stars 227 forks source link

Update Bionano: add required outputs for Genoscope assembly workflow #1274

Closed gallardoalba closed 1 year ago

bgruening commented 1 year ago

Applying linter tool_xsd... FAIL .. ERROR: Invalid XML found in file: tmp2z0ejhcp. Errors [/tmp/tmp2z0ejhcp:448:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'. /tmp/tmp2z0ejhcp:498:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'. /tmp/tmp2z0ejhcp:549:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'. /tmp/tmp2z0ejhcp:606:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'. /tmp/tmp2z0ejhcp:662:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'. /tmp/tmp2z0ejhcp:714:0:ERROR:SCHEMASV:SCHEMAV_CVC_PATTERN_VALID: Element 'has_size', attribute 'value': [facet 'pattern'] The value '0' is not accepted by the pattern '[1-9][0-9]([kKMGTPE]i?)?'.]

linting is getting stricter :)

gallardoalba commented 1 year ago

Not sure what is the problem; it seems to be due to the number of assertions:

        for ta in test_assert:
            assertions = test.findall(ta)
            if len(assertions) == 0:
                continue
            if len(assertions) > 1:
                lint_ctx.error(f"Test {test_idx}: More than one {ta} found. Only the first is considered.")
            has_test = True
            _check_asserts(test_idx, assertions, lint_ctx)
        _check_asserts(test_idx, test.findall(".//assert_contents"), lint_ctx)

But it does not contain more than one assertion @bgruening. Or is it by test? In that case, I don't find that improvement a real improve :D

gallardoalba commented 1 year ago

Related: https://github.com/galaxyproject/galaxy/pull/12975/files#r1046040326