bgruening / galaxytools

:microscope::books: Galaxy Tool wrappers
MIT License
116 stars 227 forks source link

hifiasm: multi-file input syntax fix #1283

Closed abueg closed 1 year ago

abueg commented 1 year ago

I am sorry about the third pull request in like a week 😭

so I looked back again at the help from hifiasm and the syntax for multiple files for ONT/HiC is actually as such in the latest version:

Hi-C-partition:
    --h1 FILEs   file names of Hi-C R1  [r1_1.fq,r1_2.fq,...]
    --h2 FILEs   file names of Hi-C R2  [r2_1.fq,r2_2.fq,...]
  Ultra-Long-integration (beta):
    --ul FILEs   file names of Ultra-Long reads [r1.fq,r2.fq,...]

so I just edited the join command in the command-building part to delimit with a , instead of a space, does this look OK?

here is how the command builds when I tried this out:

image
abueg commented 1 year ago

so I put the single quotes back, and made a test that checks for the multi-input for UL, and the command built looks OK (the file paths are in single quotes), but the command reported in the logfile doesn't have the single quotes, is this OK since the paths are still getting passed properly to the program?

image
bgruening commented 1 year ago

-ul seems to have quotes, for me this looks good. Can you explain where you don't see quotes?

abueg commented 1 year ago

ah, in the logfile output (the top code block) the paths aren't in quotes, though that is probably fine since hifiasm is reading the paths correctly?

bgruening commented 1 year ago

Merci!