Fixed 2 bugs: 1) when the primary metric is default, it must be repla…

bgruening / galaxytools

:microscope::books: Galaxy Tool wrappers

MIT License

115 stars 222 forks source link

Fixed 2 bugs: 1) when the primary metric is default, it must be repla… #1347

Closed kxk302 closed 8 months ago

kxk302 commented 8 months ago

…ced by classification/regression default metric, and 2) Need to undo OHE of labels for validation set

kxk302 commented 8 months ago

Hi @anuprulez,

With the change in this PR, I managed to pass both failing test cases. I'll test this on FNN, RNN, and CNN workflows. Could you also please test it any relevant workflow you have? Thanks!

bgruening commented 8 months ago

The tests are failing @kxk302

kxk302 commented 8 months ago

The tests are failing @kxk302

Yes, looking at those!

bgruening commented 8 months ago

Can you please bump the tool version?

kxk302 commented 8 months ago

Can you please bump the tool version?

Bumped the bug fix version up.

bgruening commented 8 months ago

Will be deployed over the weekend.