search

bgruening / galaxytools

:microscope::books: Galaxy Tool wrappers
MIT License
116 stars 227 forks source link

Genbank file is not optional #1389

Open mthang opened 7 months ago

mthang commented 7 months ago

It is misleading to see the genbank is labeled as optional (line 100) in this wrapper. Line 21 tells otherwise if I am not mistaken. https://github.com/bgruening/galaxytools/blob/af8605d266717ed3453bd2a0947fed79c7098fb3/tools/mitohifi/mitohifi.xml#L21

bgruening commented 7 months ago

True, but which one is correct?

mthang commented 7 months ago

My colleague and I tested the MitoHiFI with genbank file provided , and it works. The tool fails without the genbank file. It looks like the genbank file is a requirement for MitoHiFI according to this git repo https://github.com/marcelauliano/MitoHiFi

bgruening commented 7 months ago

Ok, cool, do you remove the optional="true" or should I?

mthang commented 7 months ago

Yes. remove the optional="true" at your end. I also spotted the multiple="true" in the wrapper for the genbank file input and I dont know if the MitoHiFI could take a list of genbank file as an input.