bgruening / galaxytools

:microscope::books: Galaxy Tool wrappers
MIT License
116 stars 227 forks source link

Fix "Plot confusion matrix, precision, recall and ROC and AUC curves of tabular data" tool #1420

Closed anuprulez closed 4 months ago

anuprulez commented 5 months ago
bgruening commented 5 months ago

Let me know if the lints are fixable with a recent amount of time, otherwise we skip them for now.

anuprulez commented 5 months ago

I have added a few fixes for Python linting. I think the "file size" test will still fail because the HTML files of Plotly plots are large (>3.5 MB)

bgruening commented 5 months ago

The HTML files do not need to be included. You can check with asserts maybe?

https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-tests-test-output-assert-contents

For example for the file size with a delta, or some text that you expect to be on the website.

bgruening commented 5 months ago

The other linter warning is .. WARNING: No citations found, consider adding citations to your tool.

anuprulez commented 5 months ago

The other linter warning is .. WARNING: No citations found, consider adding citations to your tool.

yes, the XML linting got fixed locally as well after adding citations.

anuprulez commented 5 months ago

The HTML files do not need to be included. You can check with asserts maybe?

https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-tests-test-output-assert-contents

For example for the file size with a delta, or some text that you expect to be on the website.

this I will check.

anuprulez commented 5 months ago
<output name="output_confusion" file="cnf_binary_sgd.html">
            <assert_contents>
            <has_size value="3486809" delta="10000" />
            </assert_contents>
        </output>
        <output name="output_prf" file="prf_binary_sgd.html">
        <assert_contents>
            <has_size value="3486974" delta="10000" />
        </assert_contents>
        </output>

I tried to add the above changes locally to the first test, but the test did not pass. I will look at it a bit later. Python and tool linting tests pass now. thanks!

bgruening commented 4 months ago

Thanks @anuprulez