Closed anuprulez closed 4 months ago
Let me know if the lints are fixable with a recent amount of time, otherwise we skip them for now.
I have added a few fixes for Python linting. I think the "file size" test will still fail because the HTML files of Plotly plots are large (>3.5 MB)
The HTML files do not need to be included. You can check with asserts maybe?
https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-tests-test-output-assert-contents
For example for the file size with a delta, or some text that you expect to be on the website.
The other linter warning is .. WARNING: No citations found, consider adding citations to your tool.
The other linter warning is
.. WARNING: No citations found, consider adding citations to your tool.
yes, the XML linting got fixed locally as well after adding citations.
The HTML files do not need to be included. You can check with asserts maybe?
https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-tests-test-output-assert-contents
For example for the file size with a delta, or some text that you expect to be on the website.
this I will check.
<output name="output_confusion" file="cnf_binary_sgd.html">
<assert_contents>
<has_size value="3486809" delta="10000" />
</assert_contents>
</output>
<output name="output_prf" file="prf_binary_sgd.html">
<assert_contents>
<has_size value="3486974" delta="10000" />
</assert_contents>
</output>
I tried to add the above changes locally to the first test, but the test did not pass. I will look at it a bit later. Python and tool linting tests pass now. thanks!
Thanks @anuprulez
h5mlm
model format ping @bgruening thanks!