execution seems to stick if output has international characters

bgschiller / postgres_kernel

A simple Jupyter kernel for PostgreSQL

MIT License

64 stars 19 forks source link

Closed DrXyzzy closed 5 years ago

DrXyzzy commented 7 years ago

Try selecting when a value returned contains one of ãáóê etc. and the * appears indicating execution, but no output appears.

screenshot 2017-03-30 15 52 44

Ref: sagemathinc/smc/issues/1731

bgschiller commented 7 years ago

Thanks for posting this. I suspect it's crashing on those unicode characters.

I'll try and take a look at this when I have time, but it's not a project I'm very active on. Anyone reading this is welcome to take a stab at it.

ps, sorry about the slow response, I was somehow not getting notifications of these issues.

mhoangvslev commented 5 years ago

Should be cool now with latest commit

bgschiller commented 5 years ago

This seems to be fixed now. I didn't do anything to make it so, but I did install with python3. I'm guessing the str/bytes change took care of it.