search

bgstaal / multipleWindow3dScene

A quick example of how one can "synchronize" a 3d scene across multiple windows using three.js and localStorage
MIT License
16.44k stars 2.56k forks source link

Improve syntax + code formatting #39

Closed Matheus-gs closed 8 months ago

Matheus-gs commented 8 months ago

Hi! I just made some changes to improve code syntax and formatting.

First changes:

Replacing != with !== Replacing == with ===

To strictly check both value and type. This is generally a good practice if you want to ensure strict equality.

Second changes: Removing an unused event parameter

Last changes: Running alt + shift + f for better code formatting. Formatting the code consistently improves readability and makes it easier for others to understand.

Lobohombo commented 8 months ago

Gracias por su correo.. pero soy de tercera edad y no se leer su página web. por estar en inglés.

El mié., 29 de noviembre de 2023 12:41, Matheus @.***> escribió:

Hi! I just made some changes to improve code syntax and formatting.

First changes:

Replacing != with !== Replacing == with ===

To strictly check both value and type. This is generally a good practice if you want to ensure strict equality.

Second changes: Removing an unused event parameter

Last changes: Running alt + shift + f for better code formatting. Formatting the code consistently improves readability and makes it easier for others to understand.

You can view, comment on, or merge this pull request online at:

https://github.com/bgstaal/multipleWindow3dScene/pull/39 Commit Summary

File Changes

(2 files https://github.com/bgstaal/multipleWindow3dScene/pull/39/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/bgstaal/multipleWindow3dScene/pull/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEJM2TIH6BZNP34LBIAYVLTYG56VNAVCNFSM6AAAAAA776EXVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTOMJZHE2DSOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>