Closed Connorhd closed 10 years ago
I'm not sure why this would be any different when stylesheet is a string, in what way do you think it will break?
The broccoli tree will append the path of the tmp/*
folder it uses when merging or joining trees to this. This causes it to work the first time around, but subsequently (on live reload, within an ember-cli app, for example), it will point to a path that does not exist.
Additionally, what you want is to allow the stylesheet option to be a function, so why not make that explicit in the code?
stylesheet is not a path, it is either a string for one of the stylesheet types or a function, I'm not sure how it is affected by live reload (or anything to do with broccoli).
I can make the change you requested but I wanted to understand why this would cause problems.
I have mixed up stylesheet
with stylesheetPath
- my bad!
They are confusingly named! Thanks for merging this in.
No worries!
@Connorhd Thanks for your patch. This will, however, break during live reload when the stylesheet option passed in is a string.
If you add a test for
self.options.stylesheet === 'function'
, I'd be happy to merge this.