(optionally) apply optiping compression

bguiz / broccoli-sprite

BroccoliJs plugin that generates CSS image sprites

http://blog.bguiz.com/post/88719320815/broccoli-sprite-released/

16 stars 7 forks source link

(optionally) apply optiping compression #14

Closed jmonster closed 8 years ago

jmonster commented 8 years ago

optiping can drastically reduce the filesize of the output sprite, but at the cost of significantly slowing down the sprite generation step. For this reason, the feature defaults to disabled.

When using jimp with the packed layout option our sprite came out to be 648kb. With optiping enabled it was reduced to 480kb.

Dhaulagiri commented 8 years ago

@bguiz any feedback on this?

bguiz commented 8 years ago

@jmonster Thanks for this - in the README, you mention that without optipng it falls back to jimp, but in the code, there's only optipng, no jimp.

If this intentional, I can just remove the reference to jimp in the README?
Otherwise let's get the code for jimp in (unless I'm missing something here)

jmonster commented 8 years ago

Jimp came from a previous PR where we updated the node Sprite module. Or one of the modules. Whatever my other PR was 😁

jmonster commented 8 years ago

Specifically: https://github.com/bguiz/broccoli-sprite/commit/96653c69b8566e493c7042ddabc643e042f8c800 And that version of node-sprite-generator has jimp: https://github.com/selaux/node-sprite-generator#optionscompositor

However, I think I may be wrong about it being the default so I just pushed up a new commit with that language removed.

bguiz commented 8 years ago

@jmonster OK I have merged this - thanks for the work!

Released:

broccoli-sprite@0.3.0
ember-sprite@0.7.0

W: http://bguiz.com