search

bguiz / ember-cli-json-pretty

An ember-cli component that displays a JSON object in your app, which can be handy during development
1 stars 6 forks source link

Addon is not working in ember engines #10

Open alechirsch opened 5 years ago

alechirsch commented 5 years ago

I am able to use this with engines in the host application. When I try to use it inside the engine, the json-pretty component is available, but it does not render anything.

ghost commented 5 years ago

@alechirsch I'd guess this happens because this project uses an older directory structure (top level trees/ folder). You can verify this by generating a new addon and copying the relevant files to verify:

ember addon my-addon
alechirsch commented 5 years ago

@efx I am currently in the process of making those changes, I am still running into problems

https://github.com/alechirsch/ember-cli-json-pretty/tree/upgrade

ghost commented 5 years ago

interesting. What are the problems? Discussing in topic-addon-development may be more helpful FWIW; I know less about addon internals than ember applications proper.

alechirsch commented 5 years ago

@efx There are no more problems, I spoke too soon. Everything is working inside and out of engines

ghost commented 5 years ago

@alechirsch we can close this then right?

alechirsch commented 5 years ago

@efx Yes, the upgrade fixed this and the other issue