isort should run sync - Githubissues

bh / atom-python-isort

Atom.io plugin to sort Python imports

https://atom.io/packages/python-isort

MIT License

19 stars 10 forks source link

isort should run sync #19

Closed markbaas closed 7 years ago

markbaas commented 9 years ago

I wrote atom-python-autopep8 which is based on your plugin and felt that it sometimes conflicted. I figured this is because it ran on the same file at the same time. So I did the following changes

isort always runs sync
merged check and checkImports and sortImports methods as they have lots of code overlap
removed the which, if the command does not exists it will definitely return a not zero exit code

bh commented 8 years ago

@markbaas Can you please rebase your PR?

cclauss commented 7 years ago

@markbaas Bump on this one?

markbaas commented 7 years ago

I wonder if this code is still valid, there must be better code and solutions by now.