search

bh / atom-python-isort

Atom.io plugin to sort Python imports
https://atom.io/packages/python-isort
MIT License
19 stars 10 forks source link

Allow for other python language packages. #21

Open joaoponceleao opened 9 years ago

joaoponceleao commented 9 years ago

This wasn't working with MagicPython (https://github.com/MagicStack/MagicPython), (or 'Python Django' for that matter). This PR takes care of that by making the checkForPythonContext more permissible.

bh commented 8 years ago

@joaoponceleao Can you please rebase your PR?

chaffeqa commented 7 years ago

any movement on this?

joaoponceleao commented 7 years ago

Sorry about this. Not using atom anymore and quite busy. Will look into it this weekend.

cclauss commented 7 years ago

@joaoponceleao Bump on this one?

joaoponceleao commented 7 years ago

@cclauss @bh @chaffeqa Sorry about this everyone (trying to finish a phd and been out of atom for a long time so...).

I've rebased this by request. I removed @lexicalunit 's PR since it did not seem to be working with magicpython on my system. It should be noted that he has his own fork of this package (although I haven't actually tried it).

danpalmer commented 6 years ago

Hey, ping on this, I've had to install MagicPython because the built in language-python does not work with Pyton 3.5+ syntax, but now isort isn't working.

Happy to help out get this working if I can?

lexicalunit commented 6 years ago

I use MagicPython as well and atom-isort supports this.

danpalmer commented 6 years ago

Oh nice, thanks!

On 6 Dec 2017, at 17:53, Amy Troschinetz notifications@github.com wrote:

I use MagicPython as well and atom-isort supports this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.